Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove all double equals #2253

Merged
merged 5 commits into from
Aug 15, 2024
Merged

chore: remove all double equals #2253

merged 5 commits into from
Aug 15, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Aug 15, 2024

resolves #2245

Copy link

changeset-bot bot commented Aug 15, 2024

🦋 Changeset detected

Latest commit: b6c6a21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@digdir/designsystemet-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 15, 2024

Preview deployments for this pull request:

📖 Storybook 15. Aug 2024 - 09:14 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@Barsnes Barsnes marked this pull request as ready for review August 15, 2024 06:46
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a changeset as this fix changes (for the better) the truth table for active item check.

Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Barsnes Barsnes merged commit dc6e910 into next Aug 15, 2024
5 checks passed
@Barsnes Barsnes deleted the biome/noDoubleEquals branch August 15, 2024 07:15
Barsnes pushed a commit that referenced this pull request Aug 21, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/[email protected]

### Minor Changes

- Update init script to new design-tokens format
([#2255](#2255))

## @digdir/[email protected]

### Minor Changes

- SkipLink: New style
([#2260](#2260))

### Patch Changes

- Table: New hover prop and class for toggling hover on rows
([#2285](#2285))

- Table: Width is now by default `100%`
([#2285](#2285))

- AccordionHeading: Correct name on types
([#2276](#2276))

## @digdir/[email protected]

### Patch Changes

- Table: New hover prop and class for toggling hover on rows
([#2285](#2285))

- Combobox: Make controlled input adhere to `inputValue` and send all
change events
([#2267](#2267))

- AccordionHeading: Correct name on types
([#2276](#2276))

- Badge: Export component
([#2297](#2297))

- ToggleGroup, Tabs: Active item equality check is now strict
([#2253](#2253))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable noDoubleEquals rule
2 participants